search

smartcar / python-sdk

Smartcar Python SDK
MIT License
44 stars 13 forks source link

feat(exception): add retry_after header for rate limit exceptions #115

Closed naomiperez closed 1 year ago

naomiperez commented 1 year ago

Use the Retry-After response header from rate limit errors in SDK's exceptions.

Asana: https://app.asana.com/0/1203823333603132/1204206052757059/f

s-ashwinkumar commented 1 year ago

@naomiperez @rsimari Just had to add two changes :

  1. Fix the semantic-version issue : Some of the libraries used will doing pip install has changed a bit and now expect a PEP40 compatible version number. Either way the version number in our code file is just a stub and this error was happening when we were installing dev dependencies for test. When the library is actually pushed out, we regenerate the version number using the semantic-release JS package anyways, so it didn't matter.
  2. Fix the selenium helper to avoid flaky test runs : This one was the time consumer, tests were randomly failing, I initially assumed selenium script part was fine so didn't bother but finally started debugging it and realized one of the conditions is a hit or a miss so changed that to a more concrete condition.
smartcar-ci commented 1 year ago

:tada: This PR is included in version 6.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: