smartcat-labs / cassandra-diagnostics

Cassandra Node Diagnostics Tools
Apache License 2.0
51 stars 6 forks source link

Kafka reporter #220

Closed nbozic-zz closed 7 years ago

nbozic-zz commented 7 years ago

We are starting to develop Sentinel infra to accept measurements. Can you double check KafkaReport is it ok after changes we did and can you check if it will work when we spin up Sentinel infra.

nbozic-zz commented 7 years ago

Check #228 as well while you review this

nbozic-zz commented 7 years ago

Also #227 which Nikola added

mgobec commented 7 years ago

Currently measurement is reported as:

At this moment it looks ok for the initial metrics push to Sentinel. Higher level of configurability should be considered going forward (topics, partitioning, serialization,...)

nivancevic commented 7 years ago

MetricsModule uses actual Cassandra metrics' names as destination Kafka topic name. It means that dozens of Kafka topics and consumers needed to exists in order to receive all measurements. Should we change the module behavior or modify the kafka reporter?

mgobec commented 7 years ago

We need to update metrics module to generate complex measurements instead of simple measurement for each metric collected.

nivancevic commented 7 years ago

Created a new issue for complex measurements in Metrics module (#246).