smartchicago / chicagoworksforyou

A citywide dashboard with ward-by-ward views of service delivery in Chicago. Includes complete API. Built using Chicago Open311 data.
http://www.chicagoworksforyou.com
MIT License
17 stars 6 forks source link

time_to_close.json is still including 0th ward in WardData #170

Open santheo opened 11 years ago

santheo commented 11 years ago
curl http://localhost:5000/requests/time_to_close.json?count=7&service_code=4fd3b167e750846744000005&end_date=2013-05-16

{
  "WardData": {
    "0": {
      "Time": 0.00974537037037037,
      "Count": 1
    },
    "1": {
      "Time": 9.006513941099538,
      "Count": 133
    },
    "10": {
      "Time": 1.509606963738426,
      "Count": 72
    },
…
cgansen commented 11 years ago

Yes. Some SR come through with nil wards, and those are attributed to ward 0 in the daily counts. The value should be discarded or ignored.

Is this breaking something?

On Mon, Jul 29, 2013 at 5:00 PM, Sandor Weisz notifications@github.comwrote:

curl http://localhost:5000/requests/time_to_close.json?count=7&service_code=4fd3b167e750846744000005&end_date=2013-05-16

{ "WardData": { "0": { "Time": 0.00974537037037037, "Count": 1 }, "1": { "Time": 9.006513941099538, "Count": 133 }, "10": { "Time": 1.509606963738426, "Count": 72 },

— Reply to this email directly or view it on GitHubhttps://github.com/smartchicago/chicagoworksforyou/issues/170 .

cgansen@cct.org

santheo commented 11 years ago

It is. Should I strip out the 0th ward on the front-end?

cgansen commented 11 years ago

Yes, Ignore it there. Keep this open as a reminder to me to remove it from the JSON, but it's not a blocker.

santheo commented 11 years ago

Done in 637b62df6575d08f541dc85419a1fc8ee1a17727