search

smartchicago / connect-chicago-locator

Search for and view information about places where you can use a computer for free in Chicago. Part of the Connect Chicago website.
locations.weconnectchicago.org
12 stars 13 forks source link

ADMIN: Image viewer is muffed; floats to top of screen out of view #28

Closed danxoneil closed 10 years ago

danxoneil commented 11 years ago

Example, on Google Chrome: http://locations.weconnectchicago.org/location/canaryville-library-642-w-43rd-street screen shot 2013-06-25 at 8 36 53 pm

And Safari: screen shot 2013-06-25 at 9 26 44 pm

There's nothing magic about this viewer, so I'm open to a simple solution...

danxoneil commented 11 years ago

@keithgordon: any update on this?

I am open to a new solution. This might be a good place to start: http://www.flickr.com/services/apps/tags/viewer/

cc: @cgansen

keiththecomputerguy commented 11 years ago

I haven't found solution using the current image gallery. Looking for a new alternative

derekeder commented 11 years ago

This looks to be due to a negative margin being added dynamically via javascript. Removing it fixes the alignment.

screen shot 2013-08-14 at 11 48 08 am

Looks like a similar issue is happening in this thread, with a fix included.

If adding the stylesheet they mention doesn't work, this looks to be an appropriate workaround.

keiththecomputerguy commented 11 years ago

I followed the instructions in this thread

After moving bootstrap-image-gallery to a separate folder and adding " *= require /image/boostrap-image-gallery.min.css" to the application.css

the images displayed correctly

danxoneil commented 11 years ago

Thanks for hopping in on this thread, @derekeder.

@keithgordon: I've tested this on Macbook in Chrome and FF, with cache cleared.

Problem persists.

![Uploading Screen Shot 2013-08-14 at 2.05.08 PM.png . . .]() ![Uploading Screen Shot 2013-08-14 at 1.36.35 PM.png . . .]()

keiththecomputerguy commented 11 years ago

@danxoneil I also updated my twitter bootstrap (lastest version 2) javascript & css files

danxoneil commented 10 years ago

Closing this for now. If we do #30 and allow HTML in the admin, we can embed Flickr itesm and this will not be necessary any longer.

srobbin commented 10 years ago

So, this is what it looks like with an embedded Flickr slideshow:

http://images.srobbin.com/image/3U2J3F2n2c1q

The problem is, there's not a great way to hide the slideshow if no photos exist:

http://images.srobbin.com/image/1h15440p3n1Y

Either that, or I could just fix the lightbox.

srobbin commented 10 years ago

The site now uses a Flickr JavaScript slideshow:

http://locations.weconnectchicago.org/location/budlong-woods-library-5630-n-lincoln-avenue

Closed with Commit 775ab00..

danxoneil commented 10 years ago

It looks like the slideshow is hidden when there are no photos: http://locations.weconnectchicago.org/location/albany-park-library-5150-n-kimball-avenue, which is awesome. Is that right, @srobbin?

srobbin commented 10 years ago

Yeah, this plugin lets us check the number of photos before displaying the slideshow. Right now, if there are zero photos, the slideshow is hidden. Though, we can do whatever we like. e.g. Show a special message.

On Saturday, November 16, 2013, danxoneil wrote:

It looks like the slideshow is hidden when there are no photos: http://locations.weconnectchicago.org/location/albany-park-library-5150-n-kimball-avenue, which is awesome. Is that right, @srobbin https://github.com/srobbin?

— Reply to this email directly or view it on GitHubhttps://github.com/smartchicago/connect-chicago-locator/issues/28#issuecomment-28627791 .

Scott Robbin short: twitter.com/srobbin long: srobbin.com

danxoneil commented 10 years ago

Nope, this is perfect as-is.