search

smartcodeltd / release-candidate-maven-plugin

Release Candidate is a Maven plugin that makes integrating Maven projects with Continuous Delivery pipelines a little bit easier :-)
http://smartcodeltd.co.uk/release-candidate-maven-plugin
Other
23 stars 11 forks source link

Issues 8,9 IT tests #10

Closed janzyka closed 8 years ago

janzyka commented 8 years ago

It's late here, hope it makes sense and I din't make some stupid mistake/typos.

Actually to explain why this is needed. I'm using jGitFlow plugin which doesn't really meet this continuous delivery approach ... But anyway. Once I create release branch I have a CI 'stabilization' build which produces a release candidate for every commit to this branch. I'm trying to use your plugin as the first step before the artifact is produced so the build has nice 1.0-RC.X version.

This works fine until the release-finish goal is invoked on the release branch which among other things amends the pom versions on the release branch to the target 'release' version (1.0). So now on the release branch I have commit with the release version (1.0), this triggers the 'stabilization' build and this is where the plugin fails to set the RC version and the build then fails.

One may argue that this last commit to the release branch shouldn't be built as the final release package is produced from master branch once the release branch is merged to master. This is true but it would require conditional run of the 'stabilization' build and this is tricky. So leaving the process to produce yet another RC for the actual release package doesn't seem to be big problem to me.

janzyka commented 8 years ago

Actually the test with 'version' goal which is now throwing NPE shoul write to a file and assert on the file content. Was too lazy last night, if I find some time today will add that.

janzyka commented 8 years ago

I fixed the version export tests to make more sense. Added test for single module which works and did the same for multi module which throws the NulPointerException