search

smartcodeltd / release-candidate-maven-plugin

Release Candidate is a Maven plugin that makes integrating Maven projects with Continuous Delivery pipelines a little bit easier :-)
http://smartcodeltd.co.uk/release-candidate-maven-plugin
Other
23 stars 11 forks source link

Mark @threadSafe #18

Closed jonfreedman closed 5 years ago

jonfreedman commented 5 years ago

If possible it would be great to mark this plugin @threadSafe to fix the build warnings:

The following plugins are not marked @threadSafe in common:
com.smartcodeltd:release-candidate-maven-plugin:1.0-201609171818.3e8187b
jan-molak commented 5 years ago

Hey @jonfreedman - sure, would you mind raising a PR?

jonfreedman commented 5 years ago

I'll see if I can figure out which line needs changing

jonfreedman commented 5 years ago

Thanks for merging, any idea when you'll cut a release?

jan-molak commented 5 years ago

As soon as I migrate the CI process from CloudBees Dev@Cloud, which has ceased to exist, to Travis... I haven't touched Release Candidate in something like 3-4 years, so need to remember what the past Jan has done here ;-)

Bear with me.

jan-molak commented 5 years ago

OK, there are still some glitches with the build process that I'll sort out tomorrow, but the new artifact should already be available on JCenter.

jan-molak commented 5 years ago

All issues are now sorted out. Thanks for helping me make Release Candidate better, @jonfreedman 👍

jonfreedman commented 5 years ago

I'm not sure that 1.0-201910011043.383523b made it onto maven central, your download badge is still pointed @ https://bintray.com/jan-molak/maven/release-candidate-maven-plugin/1.0-201609171818.3e8187b

jan-molak commented 5 years ago

Apologies, my bad. I forgot that the artifact needs to be manually synced between Bintray and Maven central. The latest version should be available shortly.

jonfreedman commented 5 years ago

Thank you for getting this into central, maven build warning is history!

jan-molak commented 5 years ago

Splendid! Thanks for your help :-)