search

smartcodeltd / release-candidate-maven-plugin

Release Candidate is a Maven plugin that makes integrating Maven projects with Continuous Delivery pipelines a little bit easier :-)
http://smartcodeltd.co.uk/release-candidate-maven-plugin
Other
23 stars 11 forks source link

Project doesn't build on Windows platform #3

Closed cdelmas closed 8 years ago

cdelmas commented 8 years ago

When building on a Windows machine, some tests fail because of comparison failure due to difference between eol on Windows and Linux platforms (\r\n vs \n only).

As an attachment, the console trace. console.txt

jan-molak commented 8 years ago

Hey @cdelmas and many thanks for reporting this, let me have a look :-)

cdelmas commented 8 years ago

If it can help, I tried to figure out where is the problem: you have to use System.getProperty("line.separator") in the class Difference instead of hardcoded \n. This fixes some tests. For the remaining, it seems that the problem resides somewhere in the maven-plugin-testing-harness that doesn't handle well the line endings read from the pom of the teamcity-integration project.

jan-molak commented 8 years ago

@cdelmas, it should be now possible to build the project on Windows platform, many thanks for reporting the issue! :+1: