search

smartcodeltd / release-candidate-maven-plugin

Release Candidate is a Maven plugin that makes integrating Maven projects with Continuous Delivery pipelines a little bit easier :-)
http://smartcodeltd.co.uk/release-candidate-maven-plugin
Other
23 stars 11 forks source link

Fix a failing test on Windows #4

Closed cdelmas closed 8 years ago

cdelmas commented 8 years ago

Hi @jan-molak, Thank you for the patch. There is still a failing test, but I guess you don't have a Windows environment to test it, so I give you this little patch that makes the project build on Windows platform (issue #3). The project should still build anywhere else (didn't try though).

jan-molak commented 8 years ago

Thanks for a PR, interesting! I've got it passing on Windows using this custom matcher. Is mvn clean verify still failing for you when using the latest code?

cdelmas commented 8 years ago

Yes, you use this matcher for VersionMojoTest (and that works well), but I still have a failing test (com.smartcodeltd.UpdateVersionMojoTest#makes_the_version_the_only_difference_between_updated_and_original_pom) because of the hardcoded "\n" in the Difference class. That's the point of my PR; maybe you can fix it otherwise.

jan-molak commented 8 years ago

I think both PRs got merged into one, but that's OK because they both look good :smile: Thanks for your help!