search

smartcontractkit / ccip-starter-kit-foundry

This project demonstrates a couple of basic Chainlink CCIP use cases
MIT License
67 stars 42 forks source link

Migrate to v1.2 #11

Closed andrejrakic closed 4 months ago

andrejrakic commented 4 months ago

Testnet addresses currently present in the Helper.sol file are deprecated now. We need to upgrade them to v1.2 addresses and add support for Wemix and Kroma Sepolia testnets.

kamuik16 commented 4 months ago

Testnet addresses currently present in the Helper.sol file are deprecated now. We need to upgrade them to v1.2 addresses and add support for Wemix and Kroma Sepolia testnets.

Would love to take this up!

andrejrakic commented 4 months ago

Would love to take this up!

That would be amazing @kamuik16, thank you!

Feel free to check https://docs.chain.link/ccip/supported-networks/v1_2_0/testnet for details and remove deprecated test networks like Base Goerli. Once PR is ready please tag me for a review so I don't miss it 😄

Thanks once again

kamuik16 commented 4 months ago

Would love to take this up!

That would be amazing @kamuik16, thank you!

Feel free to check https://docs.chain.link/ccip/supported-networks/v1_2_0/testnet for details and remove deprecated test networks like Base Goerli. Once PR is ready please tag me for a review so I don't miss it 😄

Thanks once again

Looking at the Router, Link and WETH address and verifying it with the docs it seems fine. I see that Base Goerli is deprecated and new Wemix and Kroma Sepolia testnets are added. Am I missing something?

andrejrakic commented 4 months ago

Would love to take this up!

That would be amazing @kamuik16, thank you! Feel free to check https://docs.chain.link/ccip/supported-networks/v1_2_0/testnet for details and remove deprecated test networks like Base Goerli. Once PR is ready please tag me for a review so I don't miss it 😄 Thanks once again

Looking at the Router, Link and WETH address and verifying it with the docs it seems fine. I see that Base Goerli is deprecated and new Wemix and Kroma Sepolia testnets are added. Am I missing something?

Nope, that's it!

andrejrakic commented 4 months ago

So, to sum it up, so I don't get it wrong :|. I need to remove Base Goerli and add Wemix and Kroma Sepolia and not touch anything else. Correct me if I am wrong :)

Thanks for the follow-up, excellent question! So you will need to:

Thanks!

kamuik16 commented 4 months ago

So, to sum it up, so I don't get it wrong :|. I need to remove Base Goerli and add Wemix and Kroma Sepolia and not touch anything else. Correct me if I am wrong :)

Thanks for the follow-up, excellent question! So you will need to:

  • Remove Base Goerli
  • Remove Optimism Goerli
  • Add support for Wemix
  • Add support for Kroma Sepolia
  • Check all chain IDs, Router addresses, Link addresses, Wrapped native addresses, CCIP-BnM addresses, CCIP-LnM addresses, USDC addresses and GHO addresses from the script/Helper.sol file and compare them against values from https://docs.chain.link/ccip/supported-networks/v1_2_0/testnet. There should be no changes here if I am not mistaken, but we still need to double-check everything before merging

Thanks!

Hey @andrejrakic! Opened up a PR. Thanks!