Skip report execution on curse

smartcontractkit / ccip

Cross Chain Interoperability Protocol

Other

119 stars 47 forks source link

Skip report execution on curse #1408

Closed RayXpub closed 1 month ago

RayXpub commented 1 month ago

Motivation

The goal of this PR is to remove reverts on lane cursing for DON execution transactions. If a lane is cursed, reverting will cause the whole execution transaction to fail so any execution reports for other lanes will be blocked.

Solution

For DON execution transactions the behavior is now to skip the report and emit a SkippedReportExecution. For manual execution we still revert, otherwise the transaction will silently fail for the users.

github-actions[bot] commented 1 month ago

LCOV of commit `1cebbad` during Solidity Foundry #7990

Summary coverage rate:
  lines......: 97.6% (2160 of 2212 lines)
  functions..: 94.7% (409 of 432 functions)
  branches...: 93.4% (513 of 549 branches)

Files changed coverage rate: n/a

cl-sonarqube-production[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube