search

smartcontractkit / ccip

Cross Chain Interoperability Protocol
Other
119 stars 47 forks source link

Enforce signature verification for commit plugin in `OffRamp` #1416

Closed RayXpub closed 1 month ago

RayXpub commented 1 month ago

Motivation

The goal of this PR is to implement a check to ensure that the OCR3 signature verification is enabled for the commit plugin on config. This reduces misconfig risks and impact because previously an accidental setting of isSignatureVerificationEnabled=false for the commit plugin in the OffRamp would have required a redeploy to be fixed.

Solution

Add a check enforcing isSignatureVerificationEnabled=false for the commit plugin in _afterOC3Config.

github-actions[bot] commented 1 month ago

LCOV of commit e053354 during Solidity Foundry #8039

Summary coverage rate:
  lines......: 97.6% (2156 of 2208 lines)
  functions..: 94.9% (408 of 430 functions)
  branches...: 93.4% (513 of 549 branches)

Files changed coverage rate: n/a
cl-sonarqube-production[bot] commented 1 month ago

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube