smartcontractkit / ccip

Cross Chain Interoperability Protocol
Other
119 stars 47 forks source link

Create dummy RMN contract for testing w/o RMN verification #1418

Closed RyanRHall closed 2 weeks ago

RyanRHall commented 1 month ago

Motivation

Unblock E2E testing

Solution

Create a dummy RMN contract that doesn't verify RMN sigs or curse

github-actions[bot] commented 1 month ago

LCOV of commit 931ac32 during Solidity Foundry #8043

Summary coverage rate:
  lines......: 97.5% (2154 of 2209 lines)
  functions..: 94.4% (408 of 432 functions)
  branches...: 93.4% (512 of 548 branches)

Files changed coverage rate: n/a

:no_entry: The code coverage is too low: 97.51. Expected at least 97.6.

cl-sonarqube-production[bot] commented 1 month ago

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

RensR commented 1 month ago

Let's use the real RMN contract with dummy config instead of a new contract?

RyanRHall commented 2 weeks ago

Closing, seems this was not necessary