smartcontractkit / ccip

Cross Chain Interoperability Protocol
Other
119 stars 47 forks source link

Add sanity check in applyAllowListUpdates #1420

Closed RayXpub closed 1 month ago

RayXpub commented 1 month ago

Motivation

Currently, in the event of a misconfig where a destination chain's AllowListConfigArgs allowListEnabled is set to false while providing addresses to add to the allow list, the config will silently be skipped.

Solution

Add a sanity check to detect !allowListConfigArgs.allowListEnabled &&allowListConfigArgs.addedAllowlistedSenders.length > 0`

github-actions[bot] commented 1 month ago

LCOV of commit 15eaa28 during Solidity Foundry #8067

Summary coverage rate:
  lines......: 97.6% (2158 of 2210 lines)
  functions..: 94.9% (409 of 431 functions)
  branches...: 93.5% (514 of 550 branches)

Files changed coverage rate: n/a
cl-sonarqube-production[bot] commented 1 month ago

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube