Miscellaneous fixes and cleanups

smartcontractkit / ccip

Cross Chain Interoperability Protocol

Other

119 stars 47 forks source link

Miscellaneous fixes and cleanups #1421

Closed RayXpub closed 1 month ago

RayXpub commented 1 month ago

Motivation

The goal of this PR is to fix several miscellaneous items.

Solution

Replaces some magic numbers with constants
Default to private visibility for state variables that are not used in test helpers
Standardizes some natspec tags (consistent use of @dev instead of @notice for state variables)
Add a ConfigSet event in CCIPConfig
Asserts full equality of OCRConfigWithMeta[] in CCIPConfigTests
Add clarifying comments in NonceManager applyPreviousRampsUpdates

github-actions[bot] commented 1 month ago

LCOV of commit `5c88805` during Solidity Foundry #8075

Summary coverage rate:
  lines......: 97.6% (2159 of 2211 lines)
  functions..: 94.9% (409 of 431 functions)
  branches...: 93.5% (514 of 550 branches)

Files changed coverage rate: n/a

cl-sonarqube-production[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube