Make onRamp mutable in OffRamp

smartcontractkit / ccip

Cross Chain Interoperability Protocol

Other

119 stars 47 forks source link

Make onRamp mutable in OffRamp #1422

Closed RayXpub closed 1 month ago

RayXpub commented 1 month ago

Motivation

The goal of this PR is to reduce the misconfig risk on the OffRamp with the onRamp address. Currently, if we accidentally configure the wrong onRamp address on an existing OffRamp, the fix would involve a full redeployment + reconfig.

Solution

Make the onRamp mutable in the OffRamp.
Add onRamp address verification in the commit() function
Only allow onRamp address modification when minSeqNr == 1

github-actions[bot] commented 1 month ago

LCOV of commit `8495bb5` during Solidity Foundry #8125

Summary coverage rate:
  lines......: 97.7% (2195 of 2247 lines)
  functions..: 94.9% (411 of 433 functions)
  branches...: 93.4% (524 of 561 branches)

Files changed coverage rate: n/a

cl-sonarqube-production[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube