smartcontractkit / ccip

Cross Chain Interoperability Protocol
Other
119 stars 47 forks source link

Zp/update mockrouter #1427

Closed zeuslawyer closed 1 month ago

zeuslawyer commented 1 month ago

Specifically, allow for empty message with zero gas.

Motivation

EVM2EVMOffRamp checks the message for content and gaslimit and skips calling ccip receive if they're not present. Consequently the mock errors (ReceiverError) when sending only tokens to a smart contract. This update will help chainlink-local correctly process fork-based tests too.

Solution

The MockRouter implementation of _routeMessage was last updated in https://github.com/smartcontractkit/ccip/pull/669 and is out of sync with the logic in EVM2EVMOffRamp.

github-actions[bot] commented 1 month ago

LCOV of commit 137b5fa during Solidity Foundry #8108

Summary coverage rate:
  lines......: 97.7% (2179 of 2230 lines)
  functions..: 94.9% (409 of 431 functions)
  branches...: 93.5% (520 of 556 branches)

Files changed coverage rate: n/a
cl-sonarqube-production[bot] commented 1 month ago

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube