search

smartcontractkit / ccip

Cross Chain Interoperability Protocol
Other
119 stars 47 forks source link

switch `minSigners` to `f` in RMNRemote & RMNHome #1495

Closed RyanRHall closed 1 day ago

RyanRHall commented 1 week ago

Motivation

In CCIPHome we have a requirement on the number of supporting oracles, but on RMNHome we have a laxer requirement of n >= minObservers which is not ideal (this was also in the initial sketch). If we have n=minObservers then liveness is not guaranteed. If we express f=minObservers-1, then we need at least n >= 2f+1 for liveness.

Similar story in RMNRemote for f=minSigners-1, where n >= 2f+1 would also be required for liveness.

Solution

Drop the minObservers/minSigners in favor of f for uniformity with CCIPConfig

github-actions[bot] commented 1 week ago

LCOV of commit 26b2eb2 during Solidity Foundry #8591

Summary coverage rate:
  lines......: 97.9% (2286 of 2336 lines)
  functions..: 95.1% (429 of 451 functions)
  branches...: 93.6% (540 of 577 branches)

Files changed coverage rate: n/a
cl-sonarqube-production[bot] commented 2 days ago

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

RyanRHall commented 1 day ago

closing in favor of https://github.com/smartcontractkit/chainlink/pull/14817