search

smartcontractkit / chainlink-automation-templates

Real-world sample projects using Chainlink Automation
https://automation.chainlink-demo.app
35 stars 14 forks source link

Feature/create form #55

Closed petia-latinova closed 2 years ago

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
batch-nft-app ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 9:24AM (UTC)
batch-nft-reveal ❌ Failed (Inspect) Aug 25, 2022 at 9:24AM (UTC)
imollov commented 2 years ago

@petia-latinova the form must look like in the mockup. Currently, there are 1) missing fields, 2) unnecessary fields and 3) missing elements (divider, title).

imollov commented 2 years ago

@petia-latinova tests are failing, might be because yarn.lock is changed. Is there any reason for that?

petia-latinova commented 2 years ago

@petia-latinova tests are failing, might be because yarn.lock is changed. Is there any reason for that?

The tests were failing and the versel deploy too and I deleted them and generated again to see if that will fix the problem. I removed them now. You are right, there is no reason to be changed.

imollov commented 2 years ago

@petia-latinova pls check this best practice and refactor: https://refactoring.com/catalog/removeDoubleNegative.html

imollov commented 2 years ago

@petia-latinova same as load page, submit button is not enabled when all fields are valid.

imollov commented 2 years ago

@petia-latinova same as load page, submit button is not enabled when all fields are valid.

It's because there's no account connected. Maybe we should add a tooltip in that case?