Closed SyedAsadKazmi closed 2 months ago
Thank you for your PR, @SyedAsadKazmi! However, we can't merge it.
Regarding the SPDX-License-Identifier warning, I understand it's annoying, but since the original WETH9 contract doesn't have that line, we can't add it. For reference, take a look at this https://github.com/smartcontractkit/ccip/blob/ccip-develop/contracts/src/v0.8/ccip/test/WETH9.sol
As for the --no-commit
flag, we discussed this internally and decided to follow Foundry's official documentation for installing dependencies rather than forcing the use of this flag. Same as OpenZeppelin for example https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/README.md#foundry-git
Noted, @andrejrakic. I totally understand that.
Can you please shed some light on how to install chainlink-local (or any other dependency) without the --no-commit
flag?
Thanks.
Added SPDX license identifier to the
src/shared/WETH9.sol
file to silence this warning:Added
--no-commit
flag to the forge install command in theREADME.md
file, so as to avoid this error while executing the command: