search

smartcontractkit / chainlink-starknet

MIT License
59 stars 19 forks source link

stop giving false signal to transmit #500

Closed augustbleeds closed 3 months ago

augustbleeds commented 3 months ago

There's a bug where we are transmitting too frequently. This discovery came as an investigation into why we were over-transmitting even when the deviation threshold was not met. It happens because the LatestRoundRequested shouldn't be triggered on Starknet.

refer to: https://github.com/smartcontractkit/libocr/blob/master/offchainreporting/internal/protocol/report_generation_follower.go#L499 (libocr) https://github.com/smartcontractkit/chainlink-solana/blob/02a42e04dc42d30a41f07dd100cf1062e0c04a16/pkg/solana/median_contract.go#L64 (how solana deals with it)

cl-sonarqube-production[bot] commented 3 months ago

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube