Closed ilija42 closed 1 week ago
@ilija42 changes look good. but it's hard to know if this will break e2e tests since you're introducing some changes in the integration tests folder.
when will the corresponding relayer changes be pushed to core (chainlink)? We are actively going to be pushing new contracts and modifying the e2e tests this sprint so I want to make sure that the e2e tests are green within 1 day of this PR being merged in.
Starknet tests were passing in the chainlink-common Starknet integration test, should be the same thing? All of the changes in core will be merged within an hour.
@ilija42 changes look good. but it's hard to know if this will break e2e tests since you're introducing some changes in the integration tests folder. when will the corresponding relayer changes be pushed to core (chainlink)? We are actively going to be pushing new contracts and modifying the e2e tests this sprint so I want to make sure that the e2e tests are green within 1 day of this PR being merged in.
Starknet tests were passing in the chainlink-common Starknet integration test, should be the same thing? All of the changes in core will be merged within an hour.
Thanks! I'll add the ability to test the custom core reference https://github.com/smartcontractkit/chainlink-starknet/pull/524 and then we can retest
yay it's working -- i love seeing the ✅ .
Failed conditions
0.0% Coverage on New Code (required ≥ 75%)
core ref: 9eb801069a307d5495036f8f716ff277db95b4be