upgrade ctf - Githubissues

smartcontractkit / chainlink-starknet

MIT License

59 stars 19 forks source link

Closed jmank88 closed 1 month ago

jmank88 commented 1 month ago

augustbleeds commented 1 month ago

Hey 👋 , what's the context of these changes and what's ctf?

For the PRs that @aalu1418 is mentioning, are they needed before this PR merged in or just required at some later date.

jmank88 commented 1 month ago

Just TestOCRBasic failing:

13:58:56.72 DBG Validating test config
      error validating test config: chainlink image config validation failed: chainlink image name must be set

aalu1418 commented 1 month ago

CTF is chainlink-testing-framework the changes i mentioned needed can be added within this PR otherwise it will continue to fail

did this the testconfig changes ever get ported to starknet? https://github.com/smartcontractkit/chainlink-solana/pull/817 this might also be needed cc @lukaszcl

jmank88 commented 1 month ago

CTF is chainlink-testing-framework the changes i mentioned needed can be added within this PR otherwise it will continue to fail

Am I missing something?

aalu1418 commented 1 month ago

Am I missing something?

potentially the testconfig changes? but it could just be the .github workflow changes that are in the PR i linked 🤔

jmank88 commented 1 month ago

potentially the testconfig changes? but it could just be the .github workflow changes that are in the PR i linked 🤔

I don't see an equivalent workflow in this repo, but I was missing the field change in the nil check :crossed_fingers:

jmank88 commented 1 month ago

Still failing the same way. Where do we set the chainlink image?

aalu1418 commented 1 month ago

cl-sonarqube-production[bot] commented 1 month ago