[TT-1624] link PR to solidity review issue

Tofel commented 1 week ago

Context: https://smartcontract-it.atlassian.net/browse/TT-1624 Requires: https://github.com/smartcontractkit/.github/pull/627

Tests executed on local:

[x] no PR issue in changeset -> FAILURE
[x] Solidity Review in changeset -> do not create new one -> do not update changset -> expect: PASS
[x] No Solidity Review in changset -> no Open exists -> create new one -> update changeset -> expect: PASS
[x] No Solidity Review in changset -> Open exists -> use existing -> update changeset -> expect: PASS
[x] No Solidity Review in changset -> no Open exists -> cannot find template -> expect: FAILURE
[x] No Solidity Review in changset -> no Open exists -> cannot create new issue -> expect: FAILURE
[x] No Solidity Review in changset -> no Open exists -> cannot copy child issues -> close parent issue -> expect: FAILURE
[x] No Solidity Review in changset -> no Open exists -> cannot copy 2nd template -> close 1st cloned issue -> close parent issue -> expect: FAILURE
[x] No Solidity Review in changset -> no Open exists -> create new one -> cannot link epics to parent -> expect: FAILURE
[x] No Solidity Review in changset -> no Open exists -> create new one -> cannot link to PR issue -> expect: FAILURE
[x] No Solidity Review in changset -> more than one Open exists -> expect: FAILURE
[x] Solidity Review in changset -> doesn't exist in JIRA -> expect: FAILURE

Tests executed in CI:

[x] no PR issue in changeset -> FAILURE
[x] Solidity Review in changeset -> do not create new one -> do not update changset -> expect: PASS
[x] No Solidity Review in changset -> no Open exists -> create new one -> update changeset -> expect: PASS
[x] No Solidity Review in changset -> Open exists -> use existing -> update changeset -> expect: PASS

Regression tests executed in CI:

[x] jira issue can be extracted from PR title, etc
[x] fix version is set correctly for core changes
[x] artifact pipeline correctly processes changesets

Example of a run, where we added existing Solidity Review issue to the changeset: https://github.com/smartcontractkit/chainlink/actions/runs/10994722449/job/30523925347 Example of a run, where Solidity Review was already in the changeset: https://github.com/smartcontractkit/chainlink/actions/runs/10994146103/job/30522146509 Example of Solidity Review Artifact pipeline run: https://github.com/smartcontractkit/chainlink/actions/runs/10994609110

github-actions[bot] commented 1 week ago

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/strong-boats-brake.md

This PR has been linked to Solidity Review Jira issue: TT-1707

github-actions[bot] commented 1 week ago