fixing multinode state transition logic by register polling subscription in rpc client

smartcontractkit / chainlink

node of the decentralized oracle network, bridging on and off-chain computation

https://chain.link

Other

7.04k stars 1.72k forks source link

fixing multinode state transition logic by register polling subscription in rpc client #14534

Closed huangzhen1997 closed 1 month ago

huangzhen1997 commented 1 month ago

Description

SubscribeToFinalizedHeads and SubscribeToHeads won’t abort polling subscription after Close It could cause clients like HeadTracker to keep using subscriptions to unhealthy RPC despite MultiNode's transitioning to an unhealthy state. DoD: polling subscription must be registered

Also added a patch for subscribeNewHead when polling is enabled.

Tickets:

BCFR-946(https://smartcontract-it.atlassian.net/browse/BCFR-946

cl-sonarqube-production[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
72.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube