search

smartcontractkit / chainlink

node of the decentralized oracle network, bridging on and off-chain computation
https://chain.link
Other
6.94k stars 1.68k forks source link

[SMRT] Invalid Solhint setup #7335

Open yosriady opened 2 years ago

yosriady commented 2 years ago

Description The Solhint linting tool appears to silently swallow errors.

Basic Information The solhint setup in the main repo doesn't seem to be working, it may be failing silently because of the way the scripts are set up.

Steps to Reproduce

For example if you run the following in the contracts repo:

"lint:sol": "solhint --config .solhint.json \"src/v0.8/*.sol\""

You get the following error for several contracts:

src/v0.8/VRFV2Wrapper.sol
   2:1  error    Compiler version ^0.8.6 does not satisfy the ^0.5.8 semver requirement                             compiler-version

Additional Information

Check out bug/solhint and run:

cd contracts
yarn lint:sol
rgottleber commented 2 years ago

Thanks for raising this issue we will take a look!