smartcontractkit / external-adapters-js

Monorepo containing JavaScript implementation of external adapters
MIT License
268 stars 302 forks source link

DF-20083 s3 reader EA initial commit #3313

Closed mmcallister-cll closed 2 months ago

mmcallister-cll commented 3 months ago

Closes #DF-20083

Description

Adds EA that is capable of reading CSV files from S3

Changes

Steps to Test

  1. yarn test s3reader (from root)
  2. sanity test with file in S3

sample test body:

{
    "data":{
        "endpoint": "csv",
        "bucket": "test",
        "key": "test.csv",
        "row": "1",
        "column": "A"
    }
}

Note: may require an aws sso login --profile <profile> for testing locally

Quality Assurance

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: a015e7e2b7a5762bb7667bb7dcd74b1f4687e2bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------------- | ----- | | @chainlink/s3-csv-reader-adapter | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

alecgard commented 2 months ago

On EA naming, s3-csv-reader may be more apt

mmcallister-cll commented 2 months ago

Merging as other spot checked adapters have not had their EA FW version updated either.