smartcontractkit / external-adapters-js

Monorepo containing JavaScript implementation of external adapters
MIT License
270 stars 303 forks source link

Framework ws backoff #3350

Closed austinborn closed 3 months ago

austinborn commented 3 months ago

Description

Steps to Test

TBD

Quality Assurance

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 8ada2c86d1334f47a8eb0811614e9748c8e80581

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 85 packages | Name | Type | | ----------------------------------------------- | ----- | | @chainlink/dydx-stark-adapter | Patch | | @chainlink/historical-average-adapter | Patch | | @chainlink/apy-finance-test-adapter | Patch | | @chainlink/gm-token-adapter | Patch | | @chainlink/proof-of-reserves-adapter | Patch | | @chainlink/stader-address-list-adapter | Patch | | @chainlink/eth-beacon-adapter | Patch | | @chainlink/frxeth-exchange-rate-adapter | Patch | | @chainlink/tradermade-adapter | Patch | | @chainlink/finage-adapter | Patch | | @chainlink/elwood-adapter | Patch | | @chainlink/cfbenchmarks-adapter | Patch | | @chainlink/alphavantage-adapter | Patch | | @chainlink/dxfeed-secondary-adapter | Patch | | @chainlink/moore-hk-adapter | Patch | | @chainlink/gemini-adapter | Patch | | @chainlink/gsr-adapter | Patch | | @chainlink/alongside-adapter | Patch | | @chainlink/elven-adapter | Patch | | @chainlink/dlc-btc-por-adapter | Patch | | @chainlink/por-indexer-adapter | Patch | | @chainlink/stader-balance-adapter | Patch | | @chainlink/icap-adapter | Patch | | @chainlink/view-function-multi-chain-adapter | Patch | | @chainlink/dar-adapter | Patch | | @chainlink/s3-csv-reader-adapter | Patch | | @chainlink/iex-cloud-adapter | Patch | | @chainlink/avalanche-platform-adapter | Patch | | @chainlink/lotus-adapter | Patch | | @chainlink/openexchangerates-adapter | Patch | | @chainlink/por-address-list-adapter | Patch | | @chainlink/view-starknet-latest-answer-adapter | Patch | | @chainlink/polygon-adapter | Patch | | @chainlink/view-function-adapter | Patch | | @chainlink/tp-adapter | Patch | | @chainlink/moonbeam-address-list-adapter | Patch | | @chainlink/gramchain-adapter | Patch | | @chainlink/galaxy-adapter | Patch | | @chainlink/superstate-adapter | Patch | | @chainlink/bank-frick-adapter | Patch | | @chainlink/kaiko-adapter | Patch | | @chainlink/finnhub-adapter | Patch | | @chainlink/wbtc-address-set-adapter | Patch | | @chainlink/finalto-adapter | Patch | | @chainlink/polkadot-balance-adapter | Patch | | @chainlink/finnhub-secondary-adapter | Patch | | @chainlink/coingecko-adapter | Patch | | @chainlink/coinbase-prime-adapter | Patch | | @chainlink/nft-blue-chip-adapter | Patch | | @chainlink/ion.au-adapter | Patch | | @chainlink/starknet-gas-price-adapter | Patch | | @chainlink/clear-bank-adapter | Patch | | @chainlink/coinmetrics-adapter | Patch | | @chainlink/dxfeed-adapter | Patch | | @chainlink/oanda-adapter | Patch | | @chainlink/the-network-firm-adapter | Patch | | @chainlink/blocksize-capital-adapter | Patch | | @chainlink/ncfx-adapter | Patch | | @chainlink/trueusd-adapter | Patch | | @chainlink/cryptocompare-adapter | Minor | | @chainlink/tiingo-adapter | Patch | | @chainlink/harris-and-trotter-adapter | Patch | | @chainlink/intrinio-adapter | Patch | | @chainlink/twosigma-adapter | Patch | | @chainlink/coinmarketcap-adapter | Patch | | @chainlink/coinpaprika-adapter | Patch | | @chainlink/trumatic-matic-exchange-rate-adapter | Patch | | @chainlink/tradingeconomics-adapter | Patch | | @chainlink/token-allocation-adapter | Patch | | @chainlink/token-allocation-test-adapter | Patch | | @chainlink/renvm-address-set-adapter | Patch | | @chainlink/market-closure-adapter | Patch | | @chainlink/apy-finance-adapter | Patch | | @chainlink/bsol-price-adapter | Patch | | @chainlink/crypto-volatility-index-adapter | Patch | | @chainlink/curve-3pool-adapter | Patch | | @chainlink/defi-dozen-adapter | Patch | | @chainlink/defi-pulse-adapter | Patch | | @chainlink/dxdao-adapter | Patch | | @chainlink/linear-finance-adapter | Patch | | @chainlink/savax-price-adapter | Patch | | @chainlink/set-token-index-adapter | Patch | | @chainlink/synth-index-adapter | Patch | | @chainlink/vesper-adapter | Patch | | @chainlink/xsushi-price-adapter | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

austinborn commented 3 months ago

Single test failing:

FAIL packages/sources/cryptocompare/test/integration/adapter.test.ts (5.554 s)
  ● execute › crypto api › should return success

    expect(received).toBe(expected) // Object.is equality

    Expected: 200
    Received: 504

      40 |       mockCryptoSuccess()
      41 |       const response = await testAdapter.request(data)
    > 42 |       expect(response.statusCode).toBe(200)
         |                                   ^
      43 |       expect(response.json()).toMatchSnapshot()
      44 |     })
      45 |

      at Object.toBe (packages/sources/cryptocompare/test/integration/adapter.test.ts:42:35)
mxiao-cll commented 3 months ago

We are bumping a lot of things at the same time, have we considered like a more phased rollout or that is not really necessary here

austinborn commented 3 months ago

We are bumping a lot of things at the same time, have we considered like a more phased rollout or that is not really necessary here

Historically it's been practice to bump all EAs at once for framework updates, but we can certainly revisit that. The main concern is that if framework versions diverge then it isn't clear what capabilities a given package supports.