smartcontractkit / external-adapters-js

Monorepo containing JavaScript implementation of external adapters
MIT License
270 stars 303 forks source link

Updated balancer EA READMEs with descriptions for MAX_PAYLOAD_SIZE_LIMIT #3359

Closed karen-stepanyan closed 3 months ago

karen-stepanyan commented 3 months ago

DF-20246

Added known issues section in README files for balancer EAs that explains the connection between MAX_PAYLOAD_SIZE_LIMIT env var the EA supports and Nginx config.

Note for reviewer. Ideally this should apply to all EAs, although is currently relevant to balancer EAs as they accept an array of any size as an input parameter. I'm open to include this description in the ea-framework itself, but since the ea-framework configs are not linked to EA READMEs, I'm also ok having those explicitly in balancer EAs READMEs for now

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: a9316894108a8844c9bfd41a13ee5868467a2336

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mxiao-cll commented 3 months ago

Can we just put content in one file and point to that file?

karen-stepanyan commented 3 months ago

@mxiao-cll As I mentioned in the PR description, ideally we should have the content in a ea-framework repo and just point to it from EA READMEs, there is a separate ticket for that. Until that is done we can have the content here for each README

mmcallister-cll commented 3 months ago

these EAs all correspond to ones used by proof-of-reserves as indexers (@mxiao-cll for visibility), possibly affected by growing address lists, right?

karen-stepanyan commented 3 months ago

@mmcallister-cll Yes. It seems that i've missed couple but don't think they are used that much.

mmcallister-cll commented 3 months ago

Yeah I think we're good with this set, can always move to the others as well