search

smartcontractkit / full-blockchain-solidity-course-js

Learn Blockchain, Solidity, and Full Stack Web3 Development with Javascript
12.31k stars 2.96k forks source link

Clarify blockconfirmations should be set in networkConfig file while using TypeScript #1707

Closed RowinVanAmsterdam closed 2 years ago

RowinVanAmsterdam commented 2 years ago

Describe the enhancement

Make clear that blockconfirmations should be defined in helper-hardhat-config.ts file if you're using TypeScript instead of JavaScript.

blockconfirmations does not exist as configuration property in Hardhat (docs).

It will throw the following error: 

  Property 'blockConfirmations' does not exist on type 'HardhatNetworkConfig'.

Issue is based on 'blockConfirmations' does not exist in type 'NetworkUserConfig'. #3025

RowinVanAmsterdam commented 2 years ago

Created PR#1743

krakxn commented 2 years ago

@PatrickAlphaC

PatrickAlphaC commented 2 years ago

Yes! Thank you for this. Apologies for the confusion.