Open eloramirez1356 opened 1 month ago
thanks for raising this @eloramirez1356 ...will try and take a look.
@eloramirez1356 to verify, would making the following changes resolve the error?
src/sandbox/node/index.ts
docker-compose
→ docker compose
I envision this may not fully resolve issues, since docker-compose is used for the compose object.
Please try running this branch: issue/docker-compose and let me know how this can be improved upon to resolve the error. Or, better yet, please submit a PR with proposed changes, so we can make sure we are in alignment. Thanks so much!
@BunsDev I will try to do it after a week or 2, and let you know as soon as I can! Thanks a lot! :)
Describe the bug
docker-compose
is not working anymore because docker updated this command todocker compose
, and then some commands of this library that are usingdocker-compose
are not working anymore, like:To Reproduce In order to reproduce this, I am using MacOS with Docker version v4.32.0, and node version 18.20.3, and then running the following code:
Where I find the following error:
I was able to make it work by installing
docker-compose
using brew, but this step should not be needed and it was not needed before.Expected behavior There should not be any error from running the code, as it was working before docker newer versions. For doing so it is needed to adapt the library code to use
docker compose
instead ofdocker-compose
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):