search

smartcontractkit / hardhat-starter-kit

A repo for boilerplate code for testing, deploying, and shipping chainlink solidity code.
MIT License
1.21k stars 491 forks source link

Example of using feed registry #106

Closed aelmanaa closed 2 years ago

aelmanaa commented 2 years ago

Hello,

Should the example in this repo https://github.com/smartcontractkit/feed-registry-example be copied in hardhat-starter-kit ? We should then ask to close the former to not have several repos to maintain

PatrickAlphaC commented 2 years ago

Potentially..... The thing that makes it tricky is that the registry only works on mainnet ETH...

Maybe @rgottleber @pappas999 @solangegueiros @zeuslawyer @andrejrakic have thoughts?

I think right now I'd rather not, but whatever people like.

zeuslawyer commented 2 years ago

Wouldnt this be better as part of https://github.com/smartcontractkit/smart-contract-examples since it seems to be the example from the feed registry docs? That seems to logically be suited to colocation with the smart contract examples.

the hardhat starter kit seems to be more for starting out with hardhat tooling for smart contract development and i think it doesnt need too many examples, but more the scaffolding/boilerplate to use hardhat and hardhat-deploy etc.

That's my two cents!

Also @PatrickAlphaC - the docs indicate that feed registry is available on mainnet and kovan -- have i misunderstood something ?

aelmanaa commented 2 years ago

@zeuslawyer ok makes a lot of sense. Putting it in https://github.com/smartcontractkit/smart-contract-examples would be a good idea indeed.

andrejrakic commented 2 years ago

Closing this