Closed mattaereal closed 1 year ago
Thanks for raising the issue @mattaereal. Hi @andrejrakic , can you check if @ledgerheq/hw-transport-node-hid can be removed? I don't think the dependency is used in hardhat-starter-kit?
Thanks for raising this issue @mattaereal and for opening #116
The @ledgerhq/hw-transport-node-hid
comes from @chainlink/test-helpers
and @appliedblockchain/chainlink-contracts
dependencies. The issue is minor in my opinion because that dependency is used nowhere in the harhdat-starter-kit. If we remove those two dependencies, the issue will go away, but then some tests and tasks will fail because those files need them.
I am not a fan of manually changing the .lock
files since they are auto-generated for reason. I am suggesting the following approach:
@chainlink/test-helpers
and @appliedblockchain/chainlink-contracts
packages@chainlink/test-helpers
and @appliedblockchain/chainlink-contracts
packages
Dependency
@ledgerheq/hw-transport-node-hid fails
on^4.3.0
version with latest versions of yarn, node, and node-gyp.Steps to reproduce
A hotfix can be replacing line
158
ofyarn.lock
from"@ledgerhq/hw-transport-node-hid" "^4.3.0"
to"@ledgerhq/hw-transport-node-hid" "^5.26.0"
which is the next version seen in the rest of the packages.Alternatively, you could remove hardware wallets dependencies altogether (or just ledgers', they may seem unnecessary depending on your situation).
I'll be submitting this minor modification as a pull request momentarily.