search

smartcontractkit / hardhat-starter-kit

A repo for boilerplate code for testing, deploying, and shipping chainlink solidity code.
MIT License
1.21k stars 491 forks source link

Changing dependency hw-transport-node-hid's version #116

Closed mattaereal closed 2 years ago

mattaereal commented 2 years ago

Changing @ledgerhq/hw-transport-node-hid dependency version to ^5.26.0 in order to avoid build breaks with latest yarn/node versions.

Quick-fixes #115

PatrickAlphaC commented 2 years ago

@andrejrakic could you take a look?

Yeah idk why this has a ledger dependency

mattaereal commented 2 years ago

Gitpod is failing as well. I'd advice to remove yarn.lock from the project, and clean de package.json with latest stable versions, there are a LOT of warnings (unmet dependencies, deprecations mostly).

andrejrakic commented 2 years ago

The @ledgerhq/hw-transport-node-hid comes from @chainlink/test-helpers and @appliedblockchain/chainlink-contracts dependencies. It's not a good practice to manually change lock files.

As I said here, I think we should close this PR, refactor parts of the code that use @chainlink/test-helpers and @appliedblockchain/chainlink-contracts packages and then remove those packages from the package.json.

Thanks for raising this @mattaereal once again 🙌