search

smartcontractkit / hardhat-starter-kit

A repo for boilerplate code for testing, deploying, and shipping chainlink solidity code.
MIT License
1.2k stars 491 forks source link

updated the dev dependencies #146

Closed 0xKMG closed 1 year ago

0xKMG commented 1 year ago

ethers.getContract function used in the readPrice.js script is not available if the hardhat-deploy-ethers plugin is missing.

andrejrakic commented 1 year ago

Hi @0xKMG, we don't want to return to the hardhat-deploy-ethers plugin after migrating to the most recent version of Hardhat which uses hardhat-toolbox because we are trying to reduce the number of dependencies in the project. Let's find a workaround to create a system where if there is no PriceFeedConsumer deployed for a particular contractAddr, we deploy one, OR if there is one already, we try to connect to it something like this const priceFeedConsumerContract = await PriceFeedConsumerContract.connect(deployedPriceFeedConsumerAddress, signer);. Thanks

0xKMG commented 1 year ago

Thanks for your explanation! I kind of assumed that's the preferred way for contract like this (Patrick did the same in his course) without a second thought.

0xKMG commented 1 year ago

May I create another pull request to implement the changes you've mentioned? thanks

andrejrakic commented 1 year ago

Of course, @0xKMG, go for it!