search

smartcontractkit / hardhat-starter-kit

A repo for boilerplate code for testing, deploying, and shipping chainlink solidity code.
MIT License
1.21k stars 493 forks source link

Rename "PRIVATE_KEY" variable to "WALLET_PRIVATE_KEY" #165

Open jule64 opened 1 year ago

jule64 commented 1 year ago

I've just spent 1 hour in a Chainlink workshop struggling to start up hardhat because I assumed this variable was for the infura/alchemy private key.. I kept getting these "private key too short" error messages and even the bootcamp people didn't realise what the issue was. Using a more explicit name for this variable could resolve any confusion as I imagine others might have faced this too..

naman1402 commented 1 year ago

Can I work on this issue ?

andrejrakic commented 1 year ago

@NamanMohnani, of course, go for it! Thanks for raising this issue, @jule64

naman1402 commented 1 year ago

@andrejrakic Apparently I can not make changes in the .env file, am I supposed to make changes in the .env.example file ?

naman1402 commented 1 year ago

@andrejrakic I've submitted my PR kindly check on it.