search

smartcontractkit / hardhat-starter-kit

A repo for boilerplate code for testing, deploying, and shipping chainlink solidity code.
MIT License
1.21k stars 493 forks source link

private_key to wallet_private_key #168

Open naman1402 opened 1 year ago

naman1402 commented 1 year ago

Changed PRIVATE_KEY to WALLET_PRIVATE_KEY in .env.example to avoid confusions.

naman1402 commented 1 year ago

Kindly tag me, for feedback.

QingyangKong commented 1 year ago

Hi @NamanMohnani , why do you want to update PRIVATE_KEY to WALLET_PRIVATE_KEY?

naman1402 commented 1 year ago

Hello @QingyangKong , someone had this issue, and it caused confusion to differentiate it from other key. https://github.com/smartcontractkit/hardhat-starter-kit/issues/165#issuecomment-1537295956

QingyangKong commented 1 year ago

Can you also check the config file and readme to update the name?

naman1402 commented 1 year ago

hey @QingyangKong I just made another commit as per requirements. Kindly review and give me a feedback and merge, if possible.