smartcontractkit / hardhat-starter-kit

A repo for boilerplate code for testing, deploying, and shipping chainlink solidity code.
MIT License
1.21k stars 490 forks source link

Have config be similar to the new hardhat setup #46

Closed PatrickAlphaC closed 2 years ago

PatrickAlphaC commented 2 years ago

If you run npx hardhat for a new repo, they have a new option called Create an advanced sample project. We should set this repo up to match their syntax.

PatrickAlphaC commented 2 years ago

Checkout https://github.com/PatrickAlphaC/decentralized-raffle for some context.

That one is also in typescript though

pappas999 commented 2 years ago

thanks for raising, makes sense

0xshivamagarwal commented 2 years ago

Can I work on this issue?

PatrickAlphaC commented 2 years ago

yes!

0xshivamagarwal commented 2 years ago

should I start by creating a new project using Create an advanced sample project and add all the contracts, tasks, scripts on top of that from the current repo or is there any better way to do it?

pappas999 commented 2 years ago

@shivam-agarwal-0 you can do it whatever way you like! You can start with the sample and add/strip away things, or you can start with a blank project and then add things in slowly so that it matches the advanced sample project structure/format

0xshivamagarwal commented 2 years ago

Understood, thanks @pappas999

0xshivamagarwal commented 2 years ago

Hey @PatrickAlphaC @pappas999 , I have opened PR for the issue : #53 Please review and let me know if anything else is required.

pappas999 commented 2 years ago

Thanks so much for this @shivam-agarwal-0 , we'll try review this over the next day or so

0xshivamagarwal commented 2 years ago

@pappas999 were you able to review the PR?

pappas999 commented 2 years ago

just went through everything, LGTM. One thing I had to do though (unrelated to your change), was I had to increase the mocha-timeout in hardhat.config.js from 100000 to 300000, because the integration tests on kovan were timing out. Do you get this issue @shivam-agarwal-0 ? Wondering if it's just kovan being slow, my machine, or something else

Either way, that is unrelated to your PR, and if a change to the timeout is required, we can raise a seperate PR for it

0xshivamagarwal commented 2 years ago

@pappas999 I am not facing any timeout issues, all test cases are passing with 100000 value.

pappas999 commented 2 years ago

thanks @shivam-agarwal-0