Closed PatrickAlphaC closed 2 years ago
Checkout https://github.com/PatrickAlphaC/decentralized-raffle for some context.
That one is also in typescript though
thanks for raising, makes sense
Can I work on this issue?
yes!
should I start by creating a new project using Create an advanced sample project
and add all the contracts, tasks, scripts on top of that from the current repo or is there any better way to do it?
@shivam-agarwal-0 you can do it whatever way you like! You can start with the sample and add/strip away things, or you can start with a blank project and then add things in slowly so that it matches the advanced sample project structure/format
Understood, thanks @pappas999
Hey @PatrickAlphaC @pappas999 , I have opened PR for the issue : #53 Please review and let me know if anything else is required.
Thanks so much for this @shivam-agarwal-0 , we'll try review this over the next day or so
@pappas999 were you able to review the PR?
just went through everything, LGTM. One thing I had to do though (unrelated to your change), was I had to increase the mocha-timeout in hardhat.config.js from 100000 to 300000, because the integration tests on kovan were timing out. Do you get this issue @shivam-agarwal-0 ? Wondering if it's just kovan being slow, my machine, or something else
Either way, that is unrelated to your PR, and if a change to the timeout is required, we can raise a seperate PR for it
@pappas999 I am not facing any timeout issues, all test cases are passing with 100000 value.
thanks @shivam-agarwal-0
If you run
npx hardhat
for a new repo, they have a new option calledCreate an advanced sample project
. We should set this repo up to match their syntax.