search

smartcontractkit / hardhat-starter-kit

A repo for boilerplate code for testing, deploying, and shipping chainlink solidity code.
MIT License
1.21k stars 490 forks source link

Remove "Hardcoded" warning in `RandomNumberConsumer.sol` or clarify what it means #55

Closed JayWelsh closed 2 years ago

JayWelsh commented 2 years ago

hardhat-starter-kit/contracts/RandomNumberConsumer.sol states:

/**
 * THIS IS AN EXAMPLE CONTRACT WHICH USES HARDCODED VALUES FOR CLARITY.
 * PLEASE DO NOT USE THIS CODE IN PRODUCTION.
 */

But it's unclear what it is referring to when it says "Hardcoded values", it doesn't look like there are any hardcoded values, and the contract appears to be fine for a production deployment aside from maybe also having a withdraw function for any LINK in the contract.

Am I missing something which makes this unsuitable for a production deployment (aside from the withdraw function)? Are there any hardcoded values here?

Link for clarity: https://github.com/smartcontractkit/hardhat-starter-kit/blob/main/contracts/RandomNumberConsumer.sol#L5-L8

PatrickAlphaC commented 2 years ago

Thanks for making this! You're right there really aren't any hardcoded values in here, we should remove.