search

smartcontractkit / hardhat-starter-kit

A repo for boilerplate code for testing, deploying, and shipping chainlink solidity code.
MIT License
1.22k stars 492 forks source link

updated tests timeout #58

Closed pappas999 closed 2 years ago

pappas999 commented 2 years ago

running integration tests sometimes timeouts due to Kovan network congestion etc (plus we have a 60 second wait in the tests to wait for the callback transaction). Have found I need to increase the timeout to ensure tests don't timeout.

PatrickAlphaC commented 2 years ago

LGTM.

We should get an example where an integration test listens for the emitted event from the fulfilling call. That would be the "best" instead of our "dumb" sleep.

pappas999 commented 2 years ago

thanks. Agreed on your comment. I'll make a new issue