search

smartcontractkit / hardhat-starter-kit

A repo for boilerplate code for testing, deploying, and shipping chainlink solidity code.
MIT License
1.21k stars 490 forks source link

Add keepers example using function selector checkData #73

Open giovannidisiena opened 2 years ago

giovannidisiena commented 2 years ago

This PR extends the KeepersCounter.sol contract to add example usage of function selectors as checkData.

Tested locally and on Kovan testnet using Upkeep IDs [2028, 2029, 2030].

Corresponding tests will skip if multiplierEnabled is set to "false" in helper-hardhat-config.js.

PatrickAlphaC commented 2 years ago

Ooohhhh. I like the idea of using an example with a perforumData. @andrejrakic can you take a look?

PatrickAlphaC commented 2 years ago

Ahhh, sorry @giovannidisiena. Want to update this and we'll give it a proper look?

PatrickAlphaC commented 2 years ago

Wait.... How did @rdotterer09 approve the PR?

giovannidisiena commented 2 years ago

Ahhh, sorry @giovannidisiena. Want to update this and we'll give it a proper look?

Not a problem @PatrickAlphaC, likewise apologies for the delay. Assume you just mean to update by rebase and resolve conflicts right?

Wait.... How did @rdotterer09 approve the PR?

Lol no idea

rdotterer09 commented 2 years ago

Guys, I'm not a coder, or trader, just an investor, I'm slowly learning how to read this code business so I am no threat to you, please update me on the total I have in contract after conversion is completed, Thank You

rdotterer09 commented 2 years ago

Is important for you guys to know I have some of the contract addresses on two different hard wallets, some on Arculus and some on nano X

PatrickAlphaC commented 2 years ago

@rdotterer09 no worries, we found out anyone can approve PRs on github ahah.

PatrickAlphaC commented 2 years ago

and @giovannidisiena, yes!

rdotterer09 commented 2 years ago

Are you guys getting any closer to finishing this project? Just concerned about my losses in this lovely market crunch

giovannidisiena commented 2 years ago

Cool, should be ready for review now @PatrickAlphaC 😄

pappas999 commented 2 years ago

thanks @giovannidisiena ! @andrejrakic can you please review

giovannidisiena commented 2 years ago

Thanks @andrejrakic! Sure, that makes complete sense. Maybe if the timestamp fulfils some condition provided by checkData then checkUpkeep can return some performData upon which to act. Did you have any ideas?