Premium and gas per link variable in the deploy mocks scripts should be clarified

smartcontractkit / hardhat-starter-kit

A repo for boilerplate code for testing, deploying, and shipping chainlink solidity code.

MIT License

1.21k stars 491 forks source link

Premium and gas per link variable in the deploy mocks scripts should be clarified #90

Closed PatrickAlphaC closed 2 years ago

PatrickAlphaC commented 2 years ago

Right now, we deploy the VRFCoordinatorV2Mock as such:

    await deploy("VRFCoordinatorV2Mock", {
      from: deployer,
      log: true,
      args: [
        POINT_ONE_LINK,
        1e9, // 0.000000001 LINK per gas
      ],
    })

POINT_ONE_LINK and 1e9 are not descriptive for what each stands for, they should be something like:

BASE_FEE,
GAS_PRICE_LINK

Respectively, with a link explaining what each means.

0xdre commented 2 years ago

How would this look like for brownie. Currently trying to deploy the VRFCoordinatorV2Mock but dont know what to pass in for _baseFee and _gasPriceLink.

pappas999 commented 2 years ago

hi @misterDre, if you have any questions related to the brownie starter kit, can you please raise a question on stackoverflow, tagging Chainlink. We monitor posts there and can respond accordingly, thanks!