search

smartcontractkit / hardhat-starter-kit

A repo for boilerplate code for testing, deploying, and shipping chainlink solidity code.
MIT License
1.21k stars 491 forks source link

Fix in hardhat.config.js file #99

Closed luislucena16 closed 2 years ago

luislucena16 commented 2 years ago

hey @PatrickAlphaC I have a doubt about line 100, it is calling the RandomNumberConsumer but I should assign the V2 at the end of the name, please correct me if I am wrong.

fix

zeuslawyer commented 2 years ago

HI @luislucena16! Can you please link to the file you're referring to?

thanks!

luislucena16 commented 2 years ago

hi @zeuslawyer! Sure, https://github.com/smartcontractkit/hardhat-starter-kit/blob/main/hardhat.config.js line 100.

thank you for your response!

zeuslawyer commented 2 years ago

@luislucena16 - no problem!

I believe what you're saying makes sense. Do you want to submit a PR? In case you've never submitted one, you can fork this repo (it will be called the "upstream" repo) and then you can follow this process:

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

Let me know if you want to try that :)

luislucena16 commented 2 years ago

yes of course, I will open the PR and make the changes!

thanks :) @zeuslawyer

luislucena16 commented 2 years ago

hey @zeuslawyer I have already opened the PR, here is the link https://github.com/smartcontractkit/hardhat-starter-kit/pull/100

zeuslawyer commented 2 years ago

thanks @luislucena16 . PR approved. https://github.com/smartcontractkit/hardhat-starter-kit/pull/100

Appreciate your help!