smartcoop / design

An open source design system for Smart applications
https://design.smart.coop
Other
4 stars 1 forks source link

Example forms #132

Open thusc opened 3 years ago

thusc commented 3 years ago

It seems we have three different ways to show forms:


Wolfr commented 3 years ago

@thusc I don't understand the last question completely, can you rephrase please? The form grouping is necessary for the form layout but the panels are optional.

@emilyvandewalle Let's check if we have documented horizontal forms somewhere.

thusc commented 3 years ago

I guess I was asking if the panel/border could be removed, so I guess you answered my last question. Thanks.

emilyvandewalle commented 3 years ago

I just checked and saw we have documented horizontal forms in the component documentation under form groups https://design.smart.coop/development/docs/o-form-group.html#component-02-o-form-horizontal

Would you like me to add an example template as well with the layout of the conditional form designs in screens v1.1?

thusc commented 3 years ago

Ah I didn't that documentation (I was only looking at Inputs, instead of Form. No need to add explicit example pages now then;

What do you call "conditional form designs" ?

emilyvandewalle commented 3 years ago

Ok, thanks! I was referring to these designs: https://www.figma.com/file/Zp551KO9VgmqSIouXQahlA/Smart-Screens-v1.1?node-id=173%3A5781

thusc commented 3 years ago

Is it just the same as what you did but with o-form-group-layout--horizontal and without the panels ? If yes, I think that's ok. If there is some additional trick (maybe to have all the input fields vertically aligned), then yes.

thusc commented 3 years ago

Yes, there is another trick involved, otherwise a label is vertically centered w.r.t. the input :) So yes, please :) I'm also curious to see the button placement at the bottom of the form.

emilyvandewalle commented 3 years ago

I see, I'll add an example 👍