smartcorelib / smartcore

A comprehensive library for machine learning and numerical computing. The library provides a set of tools for linear algebra, numerical computing, optimization, and enables a generic, powerful yet still efficient approach to machine learning.

https://smartcorelib.org/

Apache License 2.0

671 stars 76 forks source link

Fix CI #227

Closed morenol closed 1 year ago

morenol commented 1 year ago

Fixes #

Checklist

[ ] My branch is up-to-date with development branch.
[ ] Everything works and tested on latest stable Rust.
[ ] Coverage and Linting have been applied

Current behaviour

New expected behaviour

Change logs

codecov-commenter commented 1 year ago

Codecov Report

Merging #227 (c7aa2dd) into development (d592b62) will increase coverage by 0.01%. The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #227      +/-   ##
===============================================
+ Coverage        43.62%   43.63%   +0.01%     
===============================================
  Files               85       85              
  Lines             7324     7324              
===============================================
+ Hits              3195     3196       +1     
+ Misses            4129     4128       -1

Impacted Files	Coverage Δ
src/optimization/line_search.rs	`23.68% <0.00%> (+2.63%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Mec-iS commented 1 year ago

looks like x86_64-pc-windows-msvc doesn't like Rust 1.65 (but works with 686)

In particular libm, I reached out to them; https://github.com/rust-lang/libm/issues/271

morenol commented 1 year ago

looks like x86_64-pc-windows-msvc doesn't like Rust 1.65 (but works with 686)

for i686 we don't run the tests (github runners are x86_64) , just stable build, probably there is a test dependency that fails, hopefully this WSL stuff will solve that issue