Closed morenol closed 1 year ago
:exclamation: No coverage uploaded for pull request base (
development@9eaae9e
). Click here to learn what that means. The diff coverage isn/a
.:exclamation: Current head fe27ce9 differs from pull request most recent head f883525. Consider uploading reports for the commit f883525 to get more accurate results
@@ Coverage Diff @@
## development #232 +/- ##
==============================================
Coverage ? 44.15%
==============================================
Files ? 85
Lines ? 7275
Branches ? 0
==============================================
Hits ? 3212
Misses ? 4063
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
src/svm/mod.rs | 32.25% <ø> (ø) |
|
src/svm/svc.rs | 33.18% <ø> (ø) |
|
src/svm/svr.rs | 44.84% <ø> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Wow, typetag is not usable in wasm, I disabled that for WASM32 target. So we have full serialization/deserialization support in all targets except WASM
that is why I wanted default to be empty feature:
default = []
so that it could compiled to Wasm, we can assume that for in-browser application serialisation is not needed in the Wasm binary.
please add some tests for Kernel serialisation/deserialisation
that is why I wanted default to be empty feature:
default = []
so that it could compiled to Wasm, we can assume that for in-browser application serialisation is not needed in the Wasm binary.please add some tests for Kernel serialisation/deserialisation
Addressed.
I agree. I think that by default we should not enable any feature
so that it could compiled to Wasm, we can assume that for in-browser application serialisation is not needed in the Wasm binary.
I think that there could be a couple of use cases in wasm where deserialization could be useful, but I think that is ok for now to partially support WASM
I think that there could be a couple of use cases in wasm where deserialization could be useful, but I think that is ok for now to partially support WASM
yes something we can add later or leave it to the implementation in JS
@morenol please double check that these changes are inline with the new features setup.
Fixes https://github.com/smartcorelib/smartcore/issues/221
Checklist
Current behaviour
New expected behaviour