Fixes for release - Githubissues

smartcorelib / smartcore

A comprehensive library for machine learning and numerical computing. The library provides a set of tools for linear algebra, numerical computing, optimization, and enables a generic, powerful yet still efficient approach to machine learning.

https://smartcorelib.org/

Apache License 2.0

671 stars 76 forks source link

Fixes for release #237

Closed morenol closed 1 year ago

morenol commented 1 year ago

Fixes #

Checklist

[ ] My branch is up-to-date with development branch.
[ ] Everything works and tested on latest stable Rust.
[ ] Coverage and Linting have been applied

Current behaviour

New expected behaviour

Change logs

Mec-iS commented 1 year ago

I think you are overthinking it. It looks quite easy to me:

wasm32-unknown is for browsers
wasm32-wasi is for other VMs that have access to binary interfaces

Also, let's try to not duplicate pipelines in tests, once we run cargo tests --all-features for each target isn't it enough? What is CI / check_features (ubuntu, --features serde) (pull_request) about?

morenol commented 1 year ago

I think you are overthinking it. It looks quite easy to me:

wasm32-unknown is for browsers

wasm32-wasi is for other VMs that have access to binary interfaces

Also, let's try to not duplicate pipelines in tests, once we run cargo tests --all-features for each target isn't it enough?

In Fluvio we use wasm32-unknown-unknown with wasmtime. I think that should not assume that thing since wasm32-unknown-unknown is supported by wasmtime

Mec-iS commented 1 year ago

Interesting, which VMs you support for Wasm32? Why you don't use Wasi?

morenol commented 1 year ago

We recently added support for WASI, but still is not enabled by default, we could consider to migrate to only use WASI in the feature but that decission has not been taken yet