smartdata-analysis-and-statistics / precmed

A doubly robust precision medicine approach to estimate and validate conditional average treatment effects
https://smartdata-analysis-and-statistics.github.io/precmed/
Apache License 2.0
4 stars 0 forks source link

Verification of examples #15

Closed NightlordTW closed 2 years ago

NightlordTW commented 2 years ago

Examples: check which examples take too much time (the examples are listed in the documentation above each method, and should be introduced by Roxygen using the @example tag). You can test the examples manually by loading all the R files in your memory and running the example code in RStudio

StanWijn commented 2 years ago

I manually checked ALL examples.

The cv_surv function (cv(response ="survival)) always seems to return the following warning and error: Error(s) occurred when estimating the ATEs in the nested subgroup using "poisson", "randomForest"; return NAs in the corresponding subgroup. Warning(s) occurred when estimating the ATEs in the nested subgroup using "poisson", "randomForest"

However, it seems that this error is normal, because all subsequent functions (plot, abc) will work. Lets ask Biogen if we can resolve this error or remove it if it is not needed.

Additionally, all examples showed the following warning: Warning message: In data.preproc.mean(fun = "cv", cate.model = cate.model, init.model = init.model, : Variable trt was recoded to 0/1 with drug0->0 and drug1->1.

However, I think for the example this is done on purpose (as previously trt was 1 / 0 and they changed it to drug0 and drug1)

StanWijn commented 2 years ago

Explained in issue #19