smartdata-analysis-and-statistics / precmed

A doubly robust precision medicine approach to estimate and validate conditional average treatment effects
https://smartdata-analysis-and-statistics.github.io/precmed/
Apache License 2.0
4 stars 0 forks source link

init.model for continuous endpoints #18

Open NightlordTW opened 1 year ago

NightlordTW commented 1 year ago

For continuous outcomes, the user need to specify init.model. Previously, this variable was initialized to a non-specified global variable as follows: init.model = init.model. Since init.model is not defined anywhere in precmed, I have set it equal to NULL by default. However, this issue still needs to be fixed.

#### PRE-PROCESSING ####
  out <- data.preproc.mean(fun = "pm", cate.model = cate.model, init.model = init.model, ps.model = ps.model,
                           score.method = score.method, data = data, prop.cutoff = prop.cutoff, ps.method = ps.method)
phoebejiang commented 1 year ago

Thanks for bringing this up. Can you be more specific about what the issue is? If we don't deal with continuous outcomes, we do not need to worry about this init.model argument. It does not show up in count or survival cv(). I was able to run cvmean() with init.model = NULL.

NightlordTW commented 1 year ago

We will revisit this issue as soon as the analyses for continuous endpoints are fully implemented