smartdata-analysis-and-statistics / precmed

A doubly robust precision medicine approach to estimate and validate conditional average treatment effects
https://smartdata-analysis-and-statistics.github.io/precmed/
Apache License 2.0
4 stars 0 forks source link

Rename functions #22

Closed StanWijn closed 1 year ago

StanWijn commented 1 year ago

check function names: dr.inference might be confusing

NightlordTW commented 1 year ago

I discussed this issue with Phoebe and Gabrielle, we would like to rename functions as follows:

jcaldasmagalhaes commented 1 year ago

i renamed all function names, function calls, and links to documentation (ex: \link{cv} ) However I see that pm and cv are still used in other situations, for example in outputs_surv.R we have on line 982 fun = "pm" should this one also be changed? @NightlordTW

jcaldasmagalhaes commented 1 year ago

Here is an overview of all function name changes

dr.inference => atefit cv => catecv cvmean => catecvmean cvsurv => catecvsurv pm => catefit pmmean => catefitmean pmsurv => catefitsurv

StanWijn commented 1 year ago

I have added a few more name changes for consistancy: pmcount => catefitcount cvcount => catecvcount drcount.inference => atefitcount drsurv.inference => atefitsurv drmean.inference => atfitmean

jcaldasmagalhaes commented 1 year ago

overview of all changed names

o cv => catecv (wrapper function) o cvcount => catecvcount o cvsurv => catecvsurv o cvmean => catecvmean

o pm => catefit (wrapper function) o pmcount => catefitcount o pmsurv => catefitsurv o pmmean => catefitmean

o dr.inference => atefit (wrapper function) o drcount.inference => atefitcount o drsurv.inference => atefitsurv o drmean.inference => atfitmean