smartdata-analysis-and-statistics / precmed

A doubly robust precision medicine approach to estimate and validate conditional average treatment effects
https://smartdata-analysis-and-statistics.github.io/precmed/
Apache License 2.0
4 stars 0 forks source link

score.method has no default (mandatory argument) #29

Closed StanWijn closed 1 year ago

StanWijn commented 1 year ago

At line 265 of outputs_count.R:

# TODO: now score.method has no default (mandatory argument)

In the output_count the score.method has no default. Lets resolve the TODO. Should we set this score.method to = "poisson" similar to the example? Or leave it without default and remove the TODO?

also need to resolve at pmcount (line 738 of outputs_count.R) and catefitmean (line 812 of outputs_continuous.R)

jcaldasmagalhaes commented 1 year ago

if we give it a default value then it can be moved down in the order of the arguments

NightlordTW commented 1 year ago

Feedback gabrielle: We dont need a default, we want to force users to specify argument